-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CGroupsV2 test #14355
Fix CGroupsV2 test #14355
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #14355 +/- ##
==========================================
+ Coverage 86.13% 86.15% +0.01%
==========================================
Files 196 196
Lines 14781 14787 +6
==========================================
+ Hits 12732 12739 +7
- Misses 1742 1743 +1
+ Partials 307 305 -2 ☔ View full report in Codecov by Sentry. |
/assign @nak3 |
Thank you so much! https://github.com/mgencur/serving-1/blob/cgroups_v2_fix/.github/workflows/kind-e2e.yaml#L85 Could you update it to |
@nak3 Thanks for the pointer. Updated. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Fix CGroupsV2 test * Fix comment
* Fix CGroupsV2 test * Fix comment
* Fix CGroupsV2 test * Fix comment
* Fix CGroupsV2 test * Fix comment Co-authored-by: Martin Gencur <mgencur@redhat.com>
* Fix CGroupsV2 test * Fix comment Co-authored-by: Martin Gencur <mgencur@redhat.com>
The tests sometimes fail with CGroups V2:
Proposed Changes
Release Note