Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeoutSeconds #15630

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix timeoutSeconds #15630

wants to merge 3 commits into from

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Nov 26, 2024

Fixes #15486

Proposed Changes

  • Enforces killing the connection when timeout expires.

Release Note


@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 26, 2024
@skonto skonto changed the title [TEST] [wip] Fix timeoutSeconds [TEST] [WIP] Fix timeoutSeconds Nov 26, 2024
@skonto skonto added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2024
@knative-prow knative-prow bot requested review from izabelacg and ReToCode November 26, 2024 20:37
Copy link

knative-prow bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@skonto skonto changed the title [TEST] [WIP] Fix timeoutSeconds [TEST-ONLY] [WIP] Fix timeoutSeconds Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.50%. Comparing base (3e45e8f) to head (4ffa8be).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15630      +/-   ##
==========================================
- Coverage   83.53%   83.50%   -0.04%     
==========================================
  Files         219      219              
  Lines       17427    17421       -6     
==========================================
- Hits        14558    14547      -11     
- Misses       2498     2504       +6     
+ Partials      371      370       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor Author

skonto commented Nov 27, 2024

/retest

1 similar comment
@skonto
Copy link
Contributor Author

skonto commented Nov 27, 2024

/retest

@skonto
Copy link
Contributor Author

skonto commented Nov 27, 2024

Conformance tests pass although body is set to "activator request timeout" as in the old PR here with maxDuration: https://github.com/knative/serving/pull/12322/files#diff-35466e0823800a5cd7310b69259cc638fb0657825c2c07c9a9d2bc99de3cfb0f
Response header can only be written once (a first write does it implicitly), so we cant return a 503.

In that PR I had:

name:               "writes first byte (HTTP OK), max duration violated, request can still timeout",
		timeoutSeconds:     10,
		maxDurationSeconds: 12,
		expectedStatus:     http.StatusOK,
		sleep:              15 * time.Second,
		initialSleep:       0,
		expectedBody:       "request timeout",

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2024
@skonto skonto changed the title [TEST-ONLY] [WIP] Fix timeoutSeconds [WIP] Fix timeoutSeconds Dec 12, 2024
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2024
@skonto skonto changed the title [WIP] Fix timeoutSeconds Fix timeoutSeconds Dec 16, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receiving response even after the timeoutSeconds is reached
2 participants