-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timeoutSeconds #15630
base: main
Are you sure you want to change the base?
Fix timeoutSeconds #15630
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15630 +/- ##
==========================================
- Coverage 83.53% 83.50% -0.04%
==========================================
Files 219 219
Lines 17427 17421 -6
==========================================
- Hits 14558 14547 -11
- Misses 2498 2504 +6
+ Partials 371 370 -1 ☔ View full report in Codecov by Sentry. |
/retest |
1 similar comment
/retest |
Conformance tests pass although body is set to "activator request timeout" as in the old PR here with maxDuration: https://github.com/knative/serving/pull/12322/files#diff-35466e0823800a5cd7310b69259cc638fb0657825c2c07c9a9d2bc99de3cfb0f In that PR I had:
|
Fixes #15486
Proposed Changes
Release Note