Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow securityContext.Privileged to be configurable #15643

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KapilSareen
Copy link

Fixes #15628

Proposed Changes

  • Added support for configuring the Privileged field in securityContext.
    • The Privileged field can now be explicitly set to false by the user.
    • Default behavior (when unset) remains unchanged as nil.

Copy link

linux-foundation-easycla bot commented Dec 2, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot requested review from ReToCode and skonto December 2, 2024 11:13
Copy link

knative-prow bot commented Dec 2, 2024

Welcome @KapilSareen! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 2, 2024
Copy link

knative-prow bot commented Dec 2, 2024

Hi @KapilSareen. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

knative-prow bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KapilSareen
Once this PR has been reviewed and has the lgtm label, please assign salaboy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 2, 2024
hack/schemapatch-config.yaml Outdated Show resolved Hide resolved
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2024
@KapilSareen
Copy link
Author

Hi @skonto, I’ve addressed the reviews on my end. Let me know if there’s anything else needed.

@KapilSareen KapilSareen requested a review from skonto December 5, 2024 07:33
@skonto
Copy link
Contributor

skonto commented Dec 13, 2024

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuration of securityContext.Privileged explicitly to default value
2 participants