Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.16] Fix configuration metadata inconsistency #15650

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #15601

Fixes a problem in configuration reconciliation where labeler creates a different order of the route names listed via the annotation `serving.knative.dev/routes` compared to the configuration reconciler.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 12, 2024
@knative-prow knative-prow bot requested review from izabelacg and skonto December 12, 2024 14:05
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.55%. Comparing base (6a27004) to head (0660643).
Report is 1 commits behind head on release-1.16.

Files with missing lines Patch % Lines
pkg/reconciler/labeler/accessors.go 50.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.16   #15650      +/-   ##
================================================
- Coverage         83.57%   83.55%   -0.03%     
================================================
  Files               219      219              
  Lines             17421    17427       +6     
================================================
+ Hits              14560    14561       +1     
- Misses             2491     2496       +5     
  Partials            370      370              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Dec 12, 2024

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
Copy link

knative-prow bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2024
@knative-prow knative-prow bot merged commit a230c06 into knative:release-1.16 Dec 12, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants