Drop the use dprotaso/controller-tools fork #15664
Open
+967
−691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping the fork up to date is not really tenable and it's fairly complex. We now simply manipulate the resulting CRD yaml after generation
knative-prow
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
cc @skonto I need to revisit some new attributes that were added so marking WIP for now |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15664 +/- ##
==========================================
- Coverage 83.54% 80.85% -2.70%
==========================================
Files 219 222 +3
Lines 17427 18005 +578
==========================================
- Hits 14560 14558 -2
- Misses 2497 3077 +580
Partials 370 370 ☔ View full report in Codecov by Sentry. |
dprotaso
commented
Dec 28, 2024
| @@ -107,7 +107,6 @@ func NewFeaturesConfigFromMap(data map[string]string) (*Features, error) { | |||
| asFlag("kubernetes.containerspec-addcapabilities", &nc.ContainerSpecAddCapabilities), | |||
| asFlag("kubernetes.podspec-tolerations", &nc.PodSpecTolerations), | |||
| asFlag("kubernetes.podspec-volumes-emptydir", &nc.PodSpecVolumesEmptyDir), | |||
| asFlag("kubernetes.podspec-hostipc", &nc.PodSpecHostIPC), | |||
dprotaso
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
|
/assign @skonto This should unblock your k8s bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping the fork up to date is not really tenable and it's fairly complex. We now simply manipulate the resulting CRD yaml after generation