Make (cluster-local) DNS work out of the box by default. #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-prow-robot
added
the
size/L
|
/cc @evankanderson |
ZhiminXiang
reviewed
Jul 26, 2018
| Port: PortNumber, | ||
| }}, | ||
| Type: corev1.ServiceTypeExternalName, | ||
| ExternalName: "knative-ingressgateway.istio-system.svc.cluster.local", |
There was a problem hiding this comment.
I would prefer using K8sGatewayServiceFullname here.
tcnghia
force-pushed
the
domain-local
branch
2 times, most recently
from
62ac6ac
to
68d9d9a
Compare
google-prow-robot
added
size/M
|
@ZhiminXiang PTAL |
|
/test pull-knative-serving-unit-tests |
|
/lgtm |
This keeps existing behavior with `cluster.local` domain, but allow Pods without sidecar to access the same.
|
New changes are detected. LGTM label has been removed. |
google-prow-robot
added
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tcnghia, ZhiminXiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
|
The following is the coverage report on pkg/.
|
tcnghia
pushed a commit
to tcnghia/serving
that referenced
this pull request
Mar 11, 2020
From ROLES.md 1/ Reviewer of the codebase for at least 3 months. knative#1687 is 1 year old. 2/ Primary reviewer for at least 10 substantial PRs to the codebase. 7 XLs: https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+label%3Asize%2FXXL 3 Ls: https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+label%3Asize%2FXL+ 9 Ms: https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+label%3Asize%2FM 3/ 33 Reviewed PRs https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+ 4/ 81 Merged PRs https://github.com/knative/serving/pulls?q=is%3Apr+is%3Aclosed+author%3AZhiminXiang 4/ Nominated by nghia@ with no objections from other leads
tcnghia
pushed a commit
to tcnghia/serving
that referenced
this pull request
Mar 12, 2020
From ROLES.md 1/ Reviewer of the codebase for at least 3 months. knative#1687 is 1 year old. 2/ Primary reviewer for at least 10 substantial PRs to the codebase. 7 XLs: https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+label%3Asize%2FXXL 3 Ls: https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+label%3Asize%2FXL+ 9 Ms: https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+label%3Asize%2FM 3/ 33 Reviewed PRs https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+ 4/ 81 Merged PRs https://github.com/knative/serving/pulls?q=is%3Apr+is%3Aclosed+author%3AZhiminXiang 4/ Nominated by nghia@ with no objections from other leads
knative-prow-robot
pushed a commit
that referenced
this pull request
Mar 13, 2020
* Add ZhiminXiang to approvers. From ROLES.md 1/ Reviewer of the codebase for at least 3 months. #1687 is 1 year old. 2/ Primary reviewer for at least 10 substantial PRs to the codebase. 7 XLs: https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+label%3Asize%2FXXL 3 Ls: https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+label%3Asize%2FXL+ 9 Ms: https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+label%3Asize%2FM 3/ 33 Reviewed PRs https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+ 4/ 81 Merged PRs https://github.com/knative/serving/pulls?q=is%3Apr+is%3Aclosed+author%3AZhiminXiang 4/ Nominated by nghia@ with no objections from other leads * Sort the lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally proposed by @evankanderson in #1609. Related to #1598
Proposed Changes
svc.cluster.local, which:spec.domainbe a DNS-resolvable name by default, in case we want to implement Consider having Route not becomeReadyuntil DNS resolves #1598Servicecreated as the public route endpoint to be anExternalNameto the knative gateway in the ingress. This makes pods launched without the istio sidecar still able to call knative. (Tested by hand.)VirtualServicewhere the same domain could be added to theVirtualServicetwice if the cluster's domain suffix were set tosvc.cluster.local. This causes Istio to fail internal configuration propagation checks and route updates to not be applied.VirtualServicewhere match headers are added twice when suffix issvc.cluster.local.Release Note