WIP: Generate CRD definitions

[jonjohnsonjr]

Fixes #912

Proposed Changes

Use controller-tools crd generate tool to generate our CRD definitions.

[knative-prow-robot]

@jonjohnsonjr: 0 warnings.

In response to this:

Fixes #912

Proposed Changes

Use controller-tools crd generate tool to generate our CRD definitions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jonjohnsonjr
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mattmoor

If they are not already assigned, you can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jonjohnsonjr]

shortNames doesn't seem to work as expected 😢

Edit: fixed by constraining the tool to a newer version.

[jonjohnsonjr]

@mattmoor one change here that might trip people up is now needing to do:

$ ko apply -f config/crds/ -f config/

To pick up the CRDs.

[vagababov]

@mattmoor one change here that might trip people up is now needing to do:

$ ko apply -f config/crds/ -f config/

To pick up the CRDs.

Update this: https://github.com/knative/serving/blob/master/DEVELOPMENT.md

[jonjohnsonjr]

Filed kubernetes-sigs/controller-tools#173 re: versioning.

[jonjohnsonjr]

/retest

[jonjohnsonjr]

This might be blocked on kubernetes-sigs/kubebuilder#406

We need this for pkg/apis.VolatileTime (at least).

[knative-prow-robot]

@jonjohnsonjr: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-knative-serving-integration-tests	ed4b45b	link	/test pull-knative-serving-integration-tests
pull-knative-serving-upgrade-tests	ed4b45b	link	/test pull-knative-serving-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[maximilien]

This might be blocked on kubernetes-sigs/kubebuilder#406

We need this for pkg/apis.VolatileTime (at least).

Hi, @jonjohnsonjr, any update on this? Curious as we are also interested in solving #912