Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop assuming that !Gloo=Istio and that mesh is Istio only. #5782

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Stop assuming that !Gloo=Istio and that mesh is Istio only. #5782

merged 1 commit into from
Oct 29, 2019

Conversation

JRBANCEL
Copy link
Contributor

@JRBANCEL JRBANCEL commented Oct 9, 2019

Fixes knative/test-infra#1398

Proposed Changes

  • Do not assume mesh is only for Istio: rename ISTIO_MESH to MESH
  • Do not assume that it is either Istio or Gloo, we might support other meshes/gateways later

Matching knative.dev/test-infra PR: knative/test-infra#1453

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 9, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 9, 2019
@JRBANCEL JRBANCEL mentioned this pull request Oct 9, 2019
Merged
@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Oct 9, 2019
@JRBANCEL
Copy link
Contributor Author

JRBANCEL commented Oct 9, 2019

/hold
knative/test-infra#1453 needs to be merged and deployed first

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2019
chizhg
chizhg reviewed Oct 10, 2019
View reviewed changes
test/e2e-common.sh Outdated Show resolved Hide resolved
test/e2e-common.sh Outdated Show resolved Hide resolved
@markusthoemmes
Copy link
Contributor

/retest

@JRBANCEL seems like the other PR has been merged.

@markusthoemmes
Copy link
Contributor

/assign @tcnghia @adrcunha

@adrcunha
Copy link
Contributor

/retest

@adrcunha
Copy link
Contributor

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, JRBANCEL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2019
@JRBANCEL
Copy link
Contributor Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2019
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests pull-knative-serving-integration-tests 1/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-integration-tests

@JRBANCEL
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot merged commit 356bb51 into knative:master Oct 29, 2019
@adrcunha adrcunha mentioned this pull request Oct 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrcunha adrcunha adrcunha left review comments

@mattmoor-sockpuppet mattmoor-sockpuppet mattmoor-sockpuppet left review comments

@chizhg chizhg chizhg left review comments

@dgerd dgerd Awaiting requested review from dgerd

Assignees

@tcnghia tcnghia

@adrcunha adrcunha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use explicit flags to specify gateway to use in E2E tests
9 participants
@JRBANCEL @markusthoemmes @adrcunha @knative-prow-robot @knative-test-reporter-robot @chizhg @mattmoor-sockpuppet @tcnghia @googlebot