Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding standard duck label on CRD to signal this resource adheres to Addressable #5874

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Adding standard duck label on CRD to signal this resource adheres to Addressable #5874

merged 2 commits into from
Oct 25, 2019

Conversation

n3wscott
Copy link
Contributor

Adding standard duck label on CRD to signal this resource adheres to Addressable

Proposed Changes

  • Label Service and Route with duck.knative.dev/addressable=true

Release Note

* Service and Route are now labeled with duck.knative.dev/addressable=true.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 25, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 25, 2019
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/activator/handler.TestActivationHandler/throttler_timeout

mattmoor
mattmoor reviewed Oct 25, 2019
View reviewed changes
config/300-revision.yaml Outdated
@@ -19,6 +19,7 @@ metadata:
labels:
serving.knative.dev/release: devel
knative.dev/crd-install: "true"
duck.knative.dev/addressable: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean route

mattmoor
mattmoor reviewed Oct 25, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
@knative-prow-robot knative-prow-robot merged commit 5296719 into knative:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@evankanderson evankanderson Awaiting requested review from evankanderson

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@n3wscott @knative-test-reporter-robot @knative-prow-robot @mattmoor @googlebot