Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable field imagePullSecrets for PodSpec #5917

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Enable field imagePullSecrets for PodSpec #5917

merged 1 commit into from
Nov 4, 2019

Conversation

taragu
Copy link
Contributor

@taragu taragu commented Oct 31, 2019

/lint

Part of #5866

Proposed Changes

  • Enable users to specify imagePullSecrets in their service yaml

Release Note

Users will now be able to specify imagePullSecrets in their service yaml.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 31, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2019
knative-prow-robot
knative-prow-robot reviewed Oct 31, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taragu: 0 warnings.

In response to this:

/lint

Part of #5866

Proposed Changes

  • Enable users to specify imagePullSecrets in their service yaml

Release Note

Users will now be able to specify imagePullSecrets in their service yaml.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Oct 31, 2019
@taragu taragu force-pushed the image-pull-secrets branch from 25accfd to ad31936 Compare October 31, 2019 20:08
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 31, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/revision/revision.go 85.9% 86.5% 0.6

dgerd
dgerd reviewed Nov 1, 2019
View reviewed changes
Copy link

@dgerd dgerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also take a stab at updating the specification with the new field? I owe some documentation on doing so, but bumping the lastUpdated, version (1.0.1), and adding the field with a description would be great.

https://github.com/knative/docs/blob/master/docs/serving/spec/knative-api-specification-1.0.md

test/apicoverage/image/kodata/ignoredfields.yaml
@@ -98,7 +98,6 @@
- HostIPC
- ShareProcessNamespace
- SecurityContext
- ImagePullSecrets
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add an integration test :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree. I'll create an issue and work on it as a separate PR. I'll also do these for updating the docs.

This was referenced Nov 4, 2019
Closed
Open
@dgerd
Copy link

dgerd commented Nov 4, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgerd, taragu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2019
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/reconciler/nscert.Failure

@taragu
Copy link
Contributor Author

taragu commented Nov 4, 2019

/retest

@knative-prow-robot knative-prow-robot merged commit 7e47c0e into knative:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgerd dgerd dgerd left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@dgerd dgerd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@taragu @knative-metrics-robot @dgerd @knative-prow-robot @knative-test-reporter-robot @googlebot