Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kourier as an Ingress option for e2e tests #5983

Merged
merged 16 commits into from
Nov 26, 2019
Merged

Add Kourier as an Ingress option for e2e tests #5983

merged 16 commits into from
Nov 26, 2019

Conversation

bbrowning
Copy link
Contributor

Relates to #5982

Proposed Changes

  • Adds a new --kourier-version flag to enable running Integration tests with Kourier

@bbrowning
Add Kourier as an Ingress option for e2e tests
6d8b1f8 
This copies the work done for Gloo, except for Kourier. The
download-kourier.sh script just pulls in Kourier 0.2.2 (the latest)
for now like Gloo does since we do not test with multiple versions of
either.
@bbrowning
HACK: Run all tests w/ Kourier instead of Istio
d6056f2 
This commit needs to be removed from this PR before merging.
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 8, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2019
@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Nov 8, 2019
@bbrowning
Copy link
Contributor Author

This PR should not be merged as-is. It serves as a placeholder to see if all e2e tests pass on our official project infra with Kourier. If they do, the hacky commit in here that uses Kourier instead of Istio needs to be removed before merging and a proper test-infra PR created to enable Kourier

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2019
@bbrowning
We need the kourier-system namespace as well
760149c 
I missed then when converting things to use the download-kourier.sh
for generating the kourier.yaml
@bbrowning
Copy link
Contributor Author

The upgrade tests are broken because they rely on Istio being installed. No big surprise there, and I'm ignoring that for the moment. That's because my same hack to force Kourier to run in the integration tests also forces Kourier to run for the upgrade tests.

@bbrowning
Copy link
Contributor Author

The integration tests are going to fail here. I'll have to wait until the run is done and poke at some of the pod logs to see what's going on.

@jmprusi
Copy link
Contributor

jmprusi commented Nov 8, 2019

@bbrowning I think we are missing setting the proper ingress class for kourier: kourier.ingress.networking.knative.dev

@bbrowning
Copy link
Contributor Author

@jmprusi you're right - so now this makes me wonder how Gloo manages to pass these tests. It must be ignoring annotations and reconciling all ingresses?

@bbrowning
Copy link
Contributor Author

This is what I get for trying to write PRs while traveling. Left a --dry-run in there...

@bbrowning
Make Kourier the default ingress AFTER serving is installed
df6a41e 
I guess I need to figure out how to run this entire e2e script locally...
@bbrowning
Copy link
Contributor Author

Oh! Kourier was written against Knative Serving 0.9 and this PR is against master. Thus, the kourier controller keeps logging kourier-system/3scale-kourier-control-675bbff5c8-zxszw[kourier-control]: {"level":"error","msg":"the server could not find the requested resource (get clusteringresses.networking.internal.knative.dev)","time":"2019-11-08T18:02:15Z"} and not doing anything.

We'll need a branch of Kourier updated to work w/ Knative master before this PR will work.

@jmprusi
Copy link
Contributor

jmprusi commented Nov 11, 2019

@bbrowning that's weird, we are actually monitoring both resources, let us review it!

@davidor
Copy link
Contributor

davidor commented Nov 11, 2019

@bbrowning We've fixed the issue in Kourier and released a new version, 0.2.3. Can you try using the new version?

@jmprusi
Copy link
Contributor

jmprusi commented Nov 13, 2019

/test pull-knative-serving-integration-tests

2 similar comments
@jmprusi
Copy link
Contributor

jmprusi commented Nov 14, 2019

/test pull-knative-serving-integration-tests

@jmprusi
Copy link
Contributor

jmprusi commented Nov 14, 2019

/test pull-knative-serving-integration-tests

@jmprusi
Copy link
Contributor

jmprusi commented Nov 14, 2019

/retest

@bbrowning
Be smarter about serving-core.yaml vs serving.yaml in upgrade tests
b36327c 
When testing on Gloo or Kourier use serving-core.yaml instead of
serving.yaml for upgrade tests.
@bbrowning
Revert "Temporarily enable route retrying logic to isolate test failu…
a856142 
…res"

This reverts commit e2e02aa.
@jmprusi
Copy link
Contributor

jmprusi commented Nov 14, 2019

/test pull-knative-serving-upgrade-tests

@jmprusi
Copy link
Contributor

jmprusi commented Nov 14, 2019

/test pull-knative-serving-integration-tests

@bbrowning
Copy link
Contributor Author

100% of integration tests passed and 9/10 of the upgrade tests pass with Kourier. I didn't really expect the upgrade tests to pass in this PR, but we're close on those.

@bbrowning
Copy link
Contributor Author

I believe this is now ready for review. But, kicking off integration tests again just to confirm we're not flaky and that nothing has drifted since the last run.

/test pull-knative-serving-integration-tests

@bbrowning bbrowning changed the title [WIP] Add Kourier as an Ingress option for e2e tests Add Kourier as an Ingress option for e2e tests Nov 23, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2019
@bbrowning
Copy link
Contributor Author

/unhold

@bbrowning
Copy link
Contributor Author

/hold cancel

You know what I meant, Prow.

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2019
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-integration-tests:

test/conformance/api/v1.TestRevisionTimeout
test/conformance/api/v1alpha1.TestCustomResourcesLimits
test/conformance/api/v1alpha1.TestRevisionTimeout
test/conformance/api/v1beta1.TestRevisionTimeout
test/e2e.TestServiceToServiceCall
test/e2e.TestServiceToServiceCallViaActivator
test/e2e.TestSubrouteLocalSTS
test/e2e.TestServiceToServiceCall/fqdn

and 5 more.

@tcnghia
Copy link
Contributor

tcnghia commented Nov 26, 2019

/test pull-knative-serving-integration-tests

@tcnghia
Copy link
Contributor

tcnghia commented Nov 26, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbrowning, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2019
@knative-prow-robot knative-prow-robot merged commit be9cdc9 into knative:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor-sockpuppet mattmoor-sockpuppet mattmoor-sockpuppet left review comments

@mattmoor mattmoor mattmoor left review comments

@davidor davidor davidor left review comments

@dprotaso dprotaso Awaiting requested review from dprotaso

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

Assignees

@tcnghia tcnghia

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bbrowning @jmprusi @davidor @knative-test-reporter-robot @tcnghia @knative-prow-robot @mattmoor @mattmoor-sockpuppet @googlebot