Make sure target annotations can exceed the configured default values.

[markusthoemmes]

Fixes #5975

Proposed Changes

Neither RPS nor concurrency based revisions can currently specify a scaling target that is higher than their respective default values. This fixes that.

Release Note

Concurrency and RPS can now be configured a higher target than their respective default values.

[knative-prow-robot]

@markusthoemmes: 0 warnings.

In response to this:

Fixes #5975

Proposed Changes

Neither RPS nor concurrency based revisions can currently specify a scaling target that is higher than their respective default values. This fixes that.

Release Note

Concurrency and RPS can now be configured a higher target than their respective default values.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/reconciler/autoscaling/OWNERS [markusthoemmes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[markusthoemmes]

/assign @vagababov

[markusthoemmes]

/assign @yanweiguo

[vagababov]

/lgtm

[yanweiguo]

/lgtm

[andyyin]

https://github.com/markusthoemmes/knative-serving/blob/6dc21bc497ebc3a057b99b9b685f564170558b5c/pkg/reconciler/autoscaling/resources/target.go#L51

But here only solve the problem of concurrency, how to deal with RPS?
I mean the current value (total and tu) of RPS is from autoscaler.Config. This configuration is a global configuration. All Revisons are the same value. How do I set different values ​​for different Revision settings?

[yanweiguo]

https://github.com/markusthoemmes/knative-serving/blob/6dc21bc497ebc3a057b99b9b685f564170558b5c/pkg/reconciler/autoscaling/resources/target.go#L51

But here only solve the problem of concurrency, how to deal with RPS?
I mean the current value (total and tu) of RPS is from autoscaler.Config. This configuration is a global configuration. All Revisons are the same value. How do I set different values ​​for different Revision settings?

For PRS:

1. Use default first: https://github.com/markusthoemmes/knative-serving/blob/6dc21bc497ebc3a057b99b9b685f564170558b5c/pkg/reconciler/autoscaling/resources/target.go#L36
2. If annotation is there, use annotation: https://github.com/markusthoemmes/knative-serving/blob/6dc21bc497ebc3a057b99b9b685f564170558b5c/pkg/reconciler/autoscaling/resources/target.go#L50

[andyyin]

https://github.com/markusthoemmes/knative-serving/blob/6dc21bc497ebc3a057b99b9b685f564170558b5c/pkg/reconciler/autoscaling/resources/target.go#L51
But here only solve the problem of concurrency, how to deal with RPS?
I mean the current value (total and tu) of RPS is from autoscaler.Config. This configuration is a global configuration. All Revisons are the same value. How do I set different values ​​for different Revision settings?

For PRS:

1. Use default first: https://github.com/markusthoemmes/knative-serving/blob/6dc21bc497ebc3a057b99b9b685f564170558b5c/pkg/reconciler/autoscaling/resources/target.go#L36
2. If annotation is there, use annotation: https://github.com/markusthoemmes/knative-serving/blob/6dc21bc497ebc3a057b99b9b685f564170558b5c/pkg/reconciler/autoscaling/resources/target.go#L50

I see, thank you