Remove generic ingress reconciler and adjust code layout to look like all others. #6002
Conversation
… all others. This removes the BaseIngressReconciler and instead sets the entire reconciler and controller up in the same way as all the other reconcilers we have. Initialization logic has been moved into `controller.go` completely, unnecessary abstractions have been removed.
|
@markusthoemmes: GitHub didn't allow me to assign the following users: wtam. Note that only knative members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow-robot
added
size/XL
There was a problem hiding this comment.
@markusthoemmes: 2 warnings.
In response to this:
Proposed Changes
This removes the BaseIngressReconciler and instead sets the entire reconciler and controller up in the same way as all the other reconcilers we have. Initialization logic has been moved into
controller.gocompletely, unnecessary abstractions have been removed.I was on the fence to break this down into smaller bits. Please let me know if you want me to do that and think this is not reviawable as-is.
Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
The following is the coverage report on the affected files.
|
|
/lgtm |
|
@wtam2018: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I'm curious if we can stop using It might be better to do that in another PR if we can? |
|
@nak3 we absolutely can. I have a second branch setup to do just that. It's quite the diff as well though, so I decided to move that out as this is already big enough. |
|
Oh, I see. Sounds great! |
|
/lgtm |
|
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests: |
|
/test pull-knative-serving-unit-tests |
Proposed Changes
This removes the BaseIngressReconciler and instead sets the entire reconciler and controller up in the same way as all the other reconcilers we have. Initialization logic has been moved into
controller.gocompletely, unnecessary abstractions have been removed.I was on the fence to break this down into smaller bits. Please let me know if you want me to do that and think this is not reviawable as-is.
Release Note
/assign @wtam @tcnghia