Add default request metrics backend in observability config

[drpmma]

Fixes #5919

Proposed Changes

• Add default request metrics backend in observability config to make it consistent with the default example value in config-observability.yaml
• Make request metrics available when using default monitoring yaml.

Release Note

Add default request metrics backend in observability config to make it consistent with the default example value in config-observability.yaml

The default example in config-observability.yaml

serving/config/config-observability.yaml

Lines 91 to 94 in ec657e7

	# metrics.request-metrics-backend-destination specifies the request metrics
	# destination. If non-empty, it enables queue proxy to send request metrics.
	# Currently supported values: prometheus, stackdriver.
	metrics.request-metrics-backend-destination: prometheus

[knative-prow-robot]

@drpmma: 0 warnings.

In response to this:

Fixes #5919

Proposed Changes

• Add default request metrics backend in observability config to make it consistent with the default example value in config-observability.yaml
• Make request metrics available when using default monitoring yaml.

Release Note

Add default request metrics backend in observability config to make it consistent with the default example value in config-observability.yaml

The default example in config-observability.yaml

serving/config/config-observability.yaml

Lines 91 to 94 in ec657e7

	# metrics.request-metrics-backend-destination specifies the request metrics
	# destination. If non-empty, it enables queue proxy to send request metrics.
	# Currently supported values: prometheus, stackdriver.
	metrics.request-metrics-backend-destination: prometheus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

Hi @drpmma. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yanweiguo]

Thanks for this PR.

We used empty as default as a flag to enable/disable queue-proxy request metrics when we first introduced it. I think it is stable now to enable queue-proxy request metrics to Prometheus by default.

Could you also update the description in config-observability.yaml?

[drpmma]

Thanks for this PR.

We used empty as default as a flag to enable/disable queue-proxy request metrics when we first introduced it. I think it is stable now to enable queue-proxy request metrics to Prometheus by default.

Could you also update the description in config-observability.yaml?

ok.

[yanweiguo]

/lgtm
/assign @mattmoor

[yanweiguo]

/assign @mdemirhan

[zouyee]

/lgtm

[mattmoor]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drpmma, mattmoor, zouyee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mattmoor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment