Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] PoC for pull/6088 on Istio 1.4 mesh #6065

Closed
wants to merge 7 commits into from
Closed

[WIP] PoC for pull/6088 on Istio 1.4 mesh #6065

wants to merge 7 commits into from

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Nov 19, 2019 •
edited
Loading

/lint

EDIT

This PR shows #6088 can work on Istio 1.4 w/ mesh.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 19, 2019
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 19, 2019
@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Nov 19, 2019
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests pull-knative-serving-integration-tests 1/3
pull-knative-serving-unit-tests pull-knative-serving-unit-tests 1/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/networking labels Nov 22, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nak3
To complete the pull request process, please assign vagababov
You can assign the PR to them by writing /assign @vagababov in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nak3
Copy link
Contributor Author

nak3 commented Nov 22, 2019

/retest

@nak3
Copy link
Contributor Author

nak3 commented Nov 22, 2019

/retest

@nak3 nak3 changed the title [WIP] PoC for shorten object name for Istio 1.4.0's size of regex limit in VirtualService [WIP] PoC for pull/6088 on Istio 1.4 mesh Nov 24, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/ingress/resources/virtual_service.go 87.1% 86.5% -0.6

@nak3
Copy link
Contributor Author

nak3 commented Nov 26, 2019

This can be closed as Istio 1.4 upgrade patch was merged.

@nak3 nak3 closed this Nov 26, 2019
@nak3 nak3 deleted the istio-14 branch November 26, 2019 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

Assignees
No one assigned
Labels
area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nak3 @knative-test-reporter-robot @knative-prow-robot @knative-metrics-robot @mattmoor @googlebot