Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable service links via defaults cm #8499

Merged

Conversation

vagababov
Copy link
Contributor

Permit disabling service links for the knative services

For #8498

/assign mattmoor

Permit disabling service links for the knative services
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 27, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 27, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2020
config/core/configmaps/defaults.yaml Outdated Show resolved Hide resolved
config/core/configmaps/defaults.yaml Outdated Show resolved Hide resolved
config/core/configmaps/defaults.yaml Outdated Show resolved Hide resolved
config/core/configmaps/defaults.yaml Outdated Show resolved Hide resolved
pkg/apis/config/defaults.go Outdated Show resolved Hide resolved
pkg/apis/serving/v1/revision_defaults.go Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 27, 2020
config/core/configmaps/defaults.yaml Outdated Show resolved Hide resolved
pkg/apis/serving/v1/revision_defaults.go Outdated Show resolved Hide resolved
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

pkg/apis/config/defaults_test.go Outdated Show resolved Hide resolved
pkg/apis/config/defaults_test.go Outdated Show resolved Hide resolved
@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/apis/config.TestDefaultsConfigurationFromFile
pkg/apis/config.TestStoreLoadWithContext
pkg/apis/config.TestStoreLoadWithContextOrDefaults
pkg/apis/config.TestStoreImmutableConfig
pkg/reconciler/revision/config.TestStoreLoadWithContext
pkg/reconciler/revision/config.TestStoreImmutableConfig

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/defaults.go 92.6% 93.9% 1.3

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit ac91f26 into knative:master Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants