Use remote.Head for resolving digests #9448
Conversation
Dockerhub is soon going to start charging for pulling images. Using HEAD instead of GET for resolving the digest avoids unneccesarily counting the digest resolution as a pull.
knative-prow-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: julz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
@julz: 0 warnings.
In response to this:
Dockerhub is soon going to start charging for pulling images. Using HEAD instead of GET for resolving the digests avoids unnecessarily counting the digest resolution as a pull.
Credits @vito for original issue and actual work in go-containerregistry which this PR bumps to pick up. Also thanks @jonjohnsonjr for the heads-up
Release Note
Uses HEAD rather than GET for resolving image digests, which avoids counting image digest resolution against dockerhub pull quotas./assign @markusthoemmes @mattmoor
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
Is this a dup of #9442? |
|
ha, oops, race condition I guess! Matt's was first /close |
|
@julz: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
There's also an e2e failure with this because the failure mode (at least against GCR) changes. I pinged @jonjohnsonjr about this since I think it uncovered a couple GCR bugs. |
Dockerhub is soon going to start charging for pulling images. Using HEAD instead of GET for resolving the digests avoids unnecessarily counting the digest resolution as a pull.
Credits @vito for original issue and actual work in go-containerregistry which this PR bumps to pick up. Also thanks @jonjohnsonjr for the heads-up
Release Note
/assign @markusthoemmes @mattmoor