Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendor folder and copy knative/hack contents to hack/upstream folder #3396

Closed
wants to merge 8 commits into from
Closed

Remove vendor folder and copy knative/hack contents to hack/upstream folder #3396

wants to merge 8 commits into from

Conversation

upodroid
Copy link
Member

Part of knative/infra#134

I have removed vendor folder and copied knative/hack in to hack/upstream.

Next steps:

  • verify behaviour
  • add a new action in knobots to sync knative/hack in to all repos
  • I will make the changes in serving and eventing. Other WGs will sort out their own repos.

/cc @dprotaso @evankanderson @kvmware

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 27, 2022
@upodroid upodroid changed the title Remove vendor folder and copy knative/hack contents to hack/upstream Remove vendor folder and copy knative/hack contents to hack/upstream folder Jun 27, 2022
@knative-prow knative-prow bot added the area/gcp Issues or PRs related to Google Cloud Infrastructure label Jun 27, 2022
@knative-prow
Copy link

knative-prow bot commented Jun 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022
@upodroid
Copy link
Member Author

upodroid commented Jun 27, 2022

This a bit more complex than I though.

  • Need to upstream changes I made in hack/upstream around vendor/* folder.
  • Do we need third-party/* folder?
  • Fix lint errors in knative/hack schema folder.

@evankanderson
Copy link
Member

This a bit more complex than I though.

  • Need to upstream changes I made in hack/upstream around vendor/* folder.
  • Do we need third-party/* folder?
  • Fix lint errors in knative/hack schema folder.

Generally, vendor gets managed via go mod. We've been using third_party to track / keep items which can't be imported by go mod, but for which we're not the source of truth.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2022
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2022
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2022
@knative-prow-robot
Copy link
Collaborator

@upodroid: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2022
@knative-prow
Copy link

knative-prow bot commented Nov 14, 2022

@upodroid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-knative-test-infra-prow-tests-image-build d9e49be link true /test pull-knative-test-infra-prow-tests-image-build

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 15, 2022
@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2023
@github-actions github-actions bot closed this Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/gcp Issues or PRs related to Google Cloud Infrastructure lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants