Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ":broom: Hide problematic deps within submodules" #9

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Apr 7, 2023

Reverts #7

See the reason, here: #7 (comment)

And also the discussion here: https://cloud-native.slack.com/archives/C04LY4M2G49/p1680861772230839

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 7, 2023
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 2aaf6de into main Apr 7, 2023
@cardil cardil deleted the revert-7-bugfix/containerize-problematic-deps branch April 7, 2023 11:17
@cardil
Copy link
Contributor Author

cardil commented Apr 7, 2023

Unfortunately, this rollback hasn't resolved the problem. The knative.dev/toolbox/kntest is already cached in GOPROXY. That's why it keeps finding it instead of the roll backed version:

go: downloading knative.dev/toolbox v0.0.0-20230407111620-2aaf6de75f2e
go: downloading knative.dev/toolbox/kntest v0.0.0-20230406165419-0318b24a34cf
go: knative.dev/toolbox/kntest/cmd/kntest@latest (in knative.dev/toolbox/kntest@v0.0.0-20230406165419-0318b24a34cf):
	The go.mod file for the module providing named packages contains one or
	more replace directives. It must not contain directives that would cause
	it to be interpreted differently than if it were the main module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants