Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate napari tests into its own category #1

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

ttung
Copy link

@ttung ttung commented Sep 23, 2019

  1. Run them as part of the napari install test that's run on master branches. This test now sets up a headless environment for napari display tests.
  2. Move the napari and pyqt imports inside test_display() so they don't trip up tests when napari isn't installed.
  3. Upgrade pytest version.

Test plan: named this branch -alltest, so it should hit all the test cases.

1. Run them as part of the napari install test that's run on master branches.
2. Move the napari and pyqt imports inside test_display() so they don't trip up tests when napari isn't installed.
3. Upgrade pytest version.

Test plan: named this branch -alltest, so it should hit all the test cases.
Copy link
Owner

@kne42 kne42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kne42 kne42 merged commit 1211cf2 into kne42:starfish-display-09/19 Sep 24, 2019
@ttung ttung deleted the tonytung-napari-alltest branch September 24, 2019 16:56
@ttung ttung restored the tonytung-napari-alltest branch September 24, 2019 18:04
@ttung ttung deleted the tonytung-napari-alltest branch September 25, 2019 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants