-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Add sidekiq route only accessible by administrators * Refactor AdministratorRouteConstraint * Add link to Sidekiq UI on administrator dashboard * Add system test * Add Redis to test-and-lint action
- Loading branch information
Showing
6 changed files
with
75 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
module Constraints | ||
class AdministratorRouteConstraint | ||
def matches?(request) | ||
@request = request | ||
administrator_signed_in? | ||
end | ||
|
||
private | ||
|
||
def current_administrator | ||
validate_session | ||
return unless @request.session[:administrator_id] | ||
|
||
@current_administrator ||= Administrator.find(@request.session[:administrator_id]) | ||
end | ||
|
||
def administrator_signed_in? | ||
!!current_administrator | ||
end | ||
|
||
def validate_session | ||
return if @request.session[:administrator_expires_at].nil? | ||
|
||
@request.session[:administrator_id] = nil if @request.session[:administrator_expires_at] < Time.current | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
require 'rails_helper' | ||
|
||
RSpec.describe 'Sidekiq::Web', type: :system do | ||
context 'when logged in as an administrator' do | ||
let(:administrator) { create(:administrator) } | ||
|
||
it 'can access the Sidekiq UI' do | ||
page.set_rack_session(administrator_id: administrator.id) | ||
visit sidekiq_web_path | ||
expect(page).to have_content('Sidekiq') | ||
end | ||
end | ||
|
||
context 'when logged in as a user' do | ||
it 'cannot access the Sidekiq UI' do | ||
visit sidekiq_web_path | ||
expect(page).to have_content('404') | ||
end | ||
end | ||
|
||
context 'when not logged in as an administrator' do | ||
let(:user) { create(:user) } | ||
|
||
it 'cannot access the Sidekiq UI' do | ||
sign_in user | ||
visit sidekiq_web_path | ||
expect(page).to have_content('404') | ||
end | ||
end | ||
end |