Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark krelay servers as safe to evict by the cluster autoscaler #51

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Mark krelay servers as safe to evict by the cluster autoscaler #51

merged 1 commit into from
Jul 11, 2024

Conversation

ilpianista
Copy link
Contributor

The kubernetes cluster autoscaler doesn't remove pods that are not backed by a controller object (so not created by deployment, replica set, job, stateful set etc), thus without this annotation, krelay is preventing it from removing a node

The kubernetes cluster autoscaler doesn't remove pods that are not backed by a controller object (so not created by deployment, replica set, job, stateful set etc), thus without this annotation, krelay is preventing it from removing a node
Copy link
Owner

@knight42 knight42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@knight42 knight42 merged commit 9c3276b into knight42:main Jul 11, 2024
2 checks passed
@ilpianista ilpianista deleted the feature/safe-to-evict branch July 11, 2024 14:48
@knight42
Copy link
Owner

This PR is included in the v0.1.0 release. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants