Unbreak PS audio

[fcartegnie]

Since 3b80a57, legitimate PS is totally broken.

Checking final computed channel allocation for OOB deref is sufficient (NULL in that case).

#32
This reverts commit 3b80a57.

[fabiangreffrath]

@hlef what do you say?

[hlef]

If my patch is wrong, please, revert it.

@fcartegnie are you sure that hDecoder->time_out[sce->channel] is not OOB?

[fcartegnie]

If my patch is wrong, please, revert it.

@fcartegnie are you sure that hDecoder->time_out[sce->channel] is not OOB?

crashes are in filters processing. time_out data is the reason of the NULL derefs, and it is also set on channel allocation a bit earlier, and then can't be NULL in normal operations. That can be used as a signal that something went wrong.

[basicmaster]

[I don't have real knowledge how upstream changes/fixes are propagated to Ubuntu's packages]

Will this fix also be applied (somehow automatically?) to the version that Ubuntu 20.04 ships, or do I have to open an issue at Ubuntu's Launchpad for this, to request this fix to be backported?

[fabiangreffrath]

Ubuntu already has the 2.9.2 release.

[basicmaster]

According to the package page and Launchpad, it still has 2.9.1.

[fabiangreffrath]

I see this:
https://launchpad.net/ubuntu/+source/faad2

[basicmaster]

While for Groovy Gorilla (= upcoming 20.10) 2.9.2-1 is listed, for Focal Fossa (= 20.04), still only version 2.9.1-1 is displayed (the "Focal Fossa" link also refers to the Launchpad site I posted).

[fabiangreffrath]

Sorry, I got confused by Ubuntu's stupid release code names.

[basicmaster]

I just opened a bug at Ubuntu's Launchpad here: https://bugs.launchpad.net/ubuntu/+source/faad2/+bug/1882240