Ansible host variable fixes #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue identified in #161 (and PR #162 which was accidentally closed as i was reorganizing git branches). It achieves this by updating some of the ansible configs to use a newer variable name to access the ssh hostname.
Approach
While I initially defaulted to using
ansible_default_ipv4.address- it seems as though that created problems in the past, so I just stuck with using ansible_host and ensuring this is defined ininventory.cfgDisclosure: I approached this fix with a largely automated find-and-replace strategy
Testing and possible drawbacks to this PR
I am able to get KNIX to install with this change (will be trying to run things soon). This changeset may have changed slightly more things than necessary but it shouldn't be too bad
fixes #161