Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to avoid GitHub backreferencing the PR #29

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Conversation

knl
Copy link
Owner

@knl knl commented Jul 7, 2020

Closes #26

niv-update-action changelog in a GitHub PR contains references (in the form
of owner/repo#PR_number), which GitHub nicely turns into links.
However, what GitHub also does is it creates a backreference in those
PRs back to the PR created by niv-update-action. This pollutes the
upstream projects. Thus, this change adds an option to use a redirector
service in order to still have links, but avoid having backreferences.

@knl knl force-pushed the no-backreferences branch 5 times, most recently from a5fc1a1 to fe04c43 Compare July 7, 2020 11:10
@knl knl force-pushed the no-backreferences branch 3 times, most recently from c0f6785 to 8d00994 Compare July 7, 2020 13:57
Closes #26

niv-update-action changelog in a GitHub PR contains references (in the form
of `owner/repo#PR_number`), which GitHub nicely turns into links.
However, what GitHub also does is it creates a backreference in those
PRs back to the PR created by niv-update-action. This pollutes the
upstream projects. Thus, this change adds an option to use a redirector
service in order to still have links, but avoid having backreferences.
@knl knl force-pushed the no-backreferences branch from 8d00994 to befaaae Compare July 7, 2020 13:57
@knl knl merged commit 9c691b7 into master Jul 7, 2020
@knl knl deleted the no-backreferences branch July 7, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strip mentions from the pull request message
1 participant