Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat mentions to reduce spamming of mentioned developers #31

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

knl
Copy link
Owner

@knl knl commented Jul 7, 2020

If the changelog contains anyones username (@ + username), GitHub will dutifully notify that person that they have been mentioned. This is not nice for our generated changelogs, as it spams people and brings no value (the mention is not intentional). To retain the display, yet avoid notification, we print '@' followed by an UNICODE WORD JOINER character (that has zero width, but prevents splitting at this boundary), followed by the username.

If the changelog contains anyones username (@ + username), GitHub will dutifully
notify that person that they have been mentioned. This is not nice for our
generated changelogs, as it spams people and brings no value (the mention is not
intentional). To retain the display, yet avoid notification, we print '@'
followed by an UNICODE WORD JOINER character (that has zero width, but prevents
splitting at this boundary), followed by the username.
@knl knl merged commit 15ab87f into master Jul 7, 2020
@knl knl deleted the no-mentions branch July 7, 2020 19:04
@infinisil
Copy link

Neat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants