-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kno-7538): update images to use Image component #723
base: main
Are you sure you want to change the base?
Conversation
… use new image component
…s guide and update instructions instead
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -99,15 +99,14 @@ If you are passing a JSON payload to the webhook, you can use the `json` filter | |||
|
|||
Now we can build our notification workflow that sends out a webhook when the customer has a webhook configured for the object. | |||
|
|||
Start by creating a new workflow in Knock: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the changes below, see KNO-7573
I'd like the team to weigh in on the following decisions I made for certain image types. Based on what we decide, I will update the style guide.
|
I realized that the Fetch function page has double borders (and the UI in the images is outdated). However, I will need to make that update once I have access to a larger monitor for better screenshots (Loom of me explaining). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as approved so you can move forward, I confirmed that all of the images (including renamed ones) are displaying properly.
With that being said -- I think we should review the usage of width
/height
across all of these images, and also come up with some guidelines for their use to add to the style guide. It's unclear to me how exactly they are used by Next, as their documentation says that they are not CSS styles. However, in my own testing they do seem to impact the way that images are rendered.
I think these values should probably match the dimensions of the original image, or at least fractionally (like 400
for an image with 800px width, for example). I also don't love the way that a lot of these images look when they render 100% width on the content column, and think it could be worth considering when/if to constrain the width or height of certain images
width={800} | ||
height={450} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about these (and similar usages throughout): are we getting these values from the actual image files? In this particular case, it seems like they don't align with the actual shape of the image?
It seems like these values don't determine the actual dimensions of the image, but it's probably good for them to be approximately accurate?
src="/images/integrations/extensions/connect-segment-modal.png" | ||
width={800} | ||
height={450} | ||
className="rounded-md mx-auto border border-gray-200" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I wonder about is whether we might want to add a constrained width to some of these images (esp. relevant here because the original had that).
Supposedly the height/width props on the Image
component are not used to style the image, but I tried setting width={400}
on this one locally and it did constrain it. Sometimes we have images like this one that look kind of oversized when rendered to the full column width.
Description
Many of the images used throughout the docs did not follow our style guide and use the
<Image>
component (with the classesclassName="rounded-md mx-auto border border-gray-200"
)This PR updates those image references to use the component. In the cases where an image was either very outdated, or either had a border in the image itself, I created and added a new image.
Note that I did not update
.gif
references to use the<Image>
component since the component is designed for static image optimization.From this work, a few other tasks have been flagged in the Docs project in Linear:
pull_request_template.md
Todos
border border-gray-200
classesTasks
KNO-7538