Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable tests on builds/knockout #162

Closed
brianmhunt opened this issue Jan 9, 2022 · 2 comments · Fixed by #169
Closed

Re-enable tests on builds/knockout #162

brianmhunt opened this issue Jan 9, 2022 · 2 comments · Fixed by #169

Comments

@brianmhunt
Copy link
Member

Disabled because the global ko is undefined and dummyTemplateEngine wasn't properly importing.

This may be a canary for other build issues since switching to esbuild, which we'll undoubtedly need to resolve sooner rather than later.
@brianmhunt
Copy link
Member Author

Noting:

image

@brianmhunt
Copy link
Member Author

To fix this we just need to remove test: target from knockout/Makefile and then see if make test works.

@bcdanieldickison bcdanieldickison mentioned this issue May 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable knockout build tests and fix dummyTemplateEngine import knockout/tko
1 participant
@brianmhunt