Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable knockout build tests and fix dummyTemplateEngine import #169

Merged
merged 1 commit into from
May 10, 2022

Conversation

bcdanieldickison
Copy link
Collaborator

Fixes #162 though I'm not quite sure it's the right way.

@brianmhunt
Copy link
Member

@mbest We were just trying to re-enable the testing of the compiled knockout.js but the cross-window testing went awry when we switched to esbuild (from rollup) — does this fix seem right to you?

@brianmhunt brianmhunt self-requested a review May 6, 2022 19:16
@brianmhunt brianmhunt merged commit 6a95632 into main May 10, 2022
@brianmhunt brianmhunt deleted the 162-fix-ko-tests branch May 10, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable tests on builds/knockout
4 participants