Remove mustache providers from ko build for backwards compatibility #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianmhunt
approved these changes
Oct 24, 2021
There was a problem hiding this comment.
Good catch, I agree with this. Thanks @danieldickison !
Please feel free to merge at your pleasure!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because knockout didn’t have mustache/handlebar style interpolation, there can exist templates that contain arbitrary and unrelated
{{...}}in text and attributes, which break under tko. In our case, we had some server-side rendered templates that injected (html-escaped) user-provided text, that would subsequently by bound with knockout, and on rare occasion the user-provided text included mustaches that would be parsed as bindings and fail.For this reason, I propose leaving
TextMustacheProviderandAttributeMustacheProviderout of the MultiProvider for the knockout compat build as in this PR.