Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Identifier.set_value work with inherited properties #157

Merged
merged 2 commits into from
Jan 9, 2022
Merged

Make Identifier.set_value work with inherited properties #157

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8d42a8
Make Identifier.set_value work with inherited properties
danieldickison Oct 18, 2021
ab6e9bd
Allow no-prototype objects as $data and add tests
danieldickison Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/utils.parser/src/Identifier.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,11 @@ export default class Identifier {
let leaf = this.token
let i, n, root

if (hasOwnProperty($data, leaf)) {
if ($data instanceof Object && leaf in $data) {
danieldickison marked this conversation as resolved.
Show resolved Hide resolved
root = $data
} else if (hasOwnProperty($context, leaf)) {
} else if (leaf in $context) {
root = $context
} else if (hasOwnProperty(globals, leaf)) {
} else if (leaf in globals) {
root = globals
} else {
throw new Error('Identifier::set_value -- ' +
Expand Down