Make options.bindingGlobals empty by default #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianmhunt
approved these changes
Feb 15, 2022
packages/utils/src/options.ts
Outdated
| @@ -22,7 +22,7 @@ var options = { | |||
| allowVirtualElements: true, | |||
|
|
|||
| // Global variables that can be accessed from bindings. | |||
| bindingGlobals: _global, | |||
| bindingGlobals: {}, | |||
There was a problem hiding this comment.
This should be Object.create(null) so there's no Object prototype chain to pollute. [1]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the default build safer by preventing access to things like document and fetch. For backwards compatibility, I think we need to keep
windowthe bindingGlobals for the knockout build.