created github actions for building and compile checks #204
Conversation
|
package.lock must be added for action to work. Therefore |
|
I'm not sure about the "package-lock.json".. Your branch was also not synchronized with main and the ts-settings didn't fit . I also added another pr-github-action for test automation. Checks fails as currently expected. See: |
|
I have set the tsc-pipeline to |
|
#200 is merged, tests passed |
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: |
There was a problem hiding this comment.
It doesn't seem like a matrix is needed for these, unless there's a future use where it might make sense. Since npm is just the runner, the version doesn't seem too important,
so these workflows could be simplified by removing the matrix.
There was a problem hiding this comment.
you're right. This is for the future and does not have a use right now. I remember some problems running with node v23. With a matrix you could verify which node version is valid to use (but maybe fixed with the last commits, I don't check if the node-problem exists anymore).
I made a matrix for further test or check jobs, that may come
There was a problem hiding this comment.
later test setups without jquery could use the matrix configuration, too.
|
This looks great, thank you. Is it done/ready to merge? Need a review? I had one minor comment, but I'd be ok merging this if it's looking like it's ready. |
Two worklfows:
Check TSC runs after pull request is created. Runs
npx tscto check for any compile errors. Useful afterbranch:strong_typesis merged.Build runs after pushed to main branch. Executes a
make testand stops if tests fail. Otherwise uploads content ofbuilds/knockout/distas artifacts. New release can be downloaded then in succeeded job as artifact. No manually build on local system is needed anymore.