Add knockout proper, with spec #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om 3.5 See packages/knockout/spec/README.md
Also allow package.json’s `karma.files` to overload the default (by e.g. making them watchable)
Closed
…sting If we use `dist/knockout.js` for testing the knockout package, then we have to recompile every single dependency. If we attempt to link directly to the files `src/index.js` as we do for the .es6 variants then Typescript does not inject its tslib dependencies. So we test off of `dist/knockout.es6.js`. One still has to recompile knockout to re-test every change.
See `testing.md` for details
… `funciton () {}` in binding strings
Adds option `bindingStringPreparsers`
…uilder` This may have caused a couple regressions in tests, but they should be easy to find.
Note: arguments are not yet respected by the parser/interpreter.
@mbest - what do you think of the `addCleaner` and `removeCleaner` API? Or is that just overkill?
@mbest what do you think of this API? Do you think `BindingResult` should include the node bound and binding context? That would be useful for debugging, and open up other useful possibilities - but might be outside the clean, core API.
This should be the superclass of every class that bindings descendants, e.g. `if`, `with`, `foreach`, `template`.
This patch should bring parity with #2364, subject to the individual bindings (to be a separate commit)
In tko, `valueAccessor` with a parameter sets the value of the underlying data/observable. So we pass the value needed for extending an async context by binding the function’s `this`.
Also fix the upstream fix for a custom element tests misssing a `tick` and `template`.
1. Fix the subscribable -> dependencyDetection -> … circular dependency 2. Always use `Object.setPrototypeOf`; this introduces a polyfill requirement/dependency for IE9.
Updated since merges from master.
It’s unusual & unexpected that `_contextExtensions` is being called multiple times; this may be a regression that needs investigation.
Note #69 re. foreachBehaviors.js:131
# Conflicts: # Backers.md # packages/tko/src/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re. #50