22 tc39 observables #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyle subscribe So when a TC39 style `subscribe` call is made, we trigger with the current value immediately, contrasting with the prior behaviour - namely triggering only on changes to the state. tc39/proposal-observable#190
…er arguments This will be used by the JSX utility.
Now JSX binding arguments are known at the compile-time, so this ought to work:
```js
get template () {
return <div ko-text={this.someValue}></div>
}
```
Sample:
```html
<component x={alpha}></component>
```
… will be given `params={x: alpha}`
… observable/computed
I suggest that it be done with a new event type, which could also work with regular subscriptions. tc39 observables are just another way to consume a sequence of events. I don't think we should change the nature of that sequence based on the consumption technique. |
|
Thanks @mbest, I think that's a good idea. Did you have any specifics in mind? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mbest - You can see I've added in support for the TC39
{next:...}style of argument tosubscribe.I use the argument-type (i.e. an object with a
nextmethod) to detect whether it's TC39-compliant call, in which case the current value of an observable is emitted immediately/synchronously.It occurred to me that perhaps we want to have a different approach to this, such as adding a new event type (i.e.
stateinstead ofchange). Any thoughts?