You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's well known that the Arduino IDE doesn't support changing defines at compile time in libraries. Issue #110 addresses this for another define, but I think the cons brought up in that conversation don't apply to the MQTT_KEEPALIVE define. It is only used in connect so I believe this would be simple to add as an optional argument to connect, and wouldn't take up any additional memory space.
I'm happy to submit a PR if this would theoretically get accepted.
This argument also mostly applies to MQTT_SOCKET_TIMEOUT, but it would need to be stored in the class for readByte to use it. I could make this change at the same time.
The text was updated successfully, but these errors were encountered:
It's well known that the Arduino IDE doesn't support changing defines at compile time in libraries. Issue #110 addresses this for another define, but I think the cons brought up in that conversation don't apply to the
MQTT_KEEPALIVE
define. It is only used inconnect
so I believe this would be simple to add as an optional argument toconnect
, and wouldn't take up any additional memory space.I'm happy to submit a PR if this would theoretically get accepted.
This argument also mostly applies to
MQTT_SOCKET_TIMEOUT
, but it would need to be stored in the class forreadByte
to use it. I could make this change at the same time.The text was updated successfully, but these errors were encountered: