Allow custom values for MQTT_KEEPALIVE, MQTT_SOCKET_TIMEOUT #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, the problem here is rather than just make them configurable, you've removed the constants from the header. That is a breaking change so I can't merge it. There's no reason not to Jeep those constants as the place the default values are defined if a sketch doesn't provide its own. That would be entirely backward compatible. |
FFEngr
approved these changes
Jun 29, 2019
|
I've just pushed a change that adds Given all of the other changes that have happened since this PR was first raised, and my comments above, I'm going to close this. Thank you for taking the take to propose the change - my apologies it has taken so long to come to any resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #175. I'm not sure how you feel about optional values in the header declaration, so if this is annoying for you feel free to just take the first commit.