-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to remove drag shadow decoration #9
Conversation
Due to lack of my knowledge of how PRs work it now also contain my tweaks to haptic feedback. Sorry. But in my defense these changes correspond to how most of the reorderable lists I've seen work with only one impact when reordering starts. :) |
This looks really nice :D |
@knopp Hi, do you consider to add this PR to master? As for me, it would be great if there will be an option to disable shadow decoration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On iOS it is customary to have haptic feedback during every reorder change. So this is definitely wrong. I do have several android phones and I noticed that the haptic feedback is lot less subtle, so I suppose this needs to be customizable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced flag is best approach for this. I'll prefer to have customizable decoration function or something similar at widget level. I'll look into it.
@knopp Thanks for a quick reply. I'm just interested, and if you can provide me a bit of estimate when it's possible that you make such an update with customizable decoration. I understand that you can have your work and this library is not a high priority in your life. So just raw estimate like "two weeks", "month" or "half-year" would be very helpful to me, cuz I'm currently developing an app, and there are two ways 1) wait for an update from you 2) fork your library with just that PR with a convinced flag |
Commit 20724b1 added decoratePlaceholder: (Widget item, double opacity) {
return DecoratedPlaceholder(widget: item, offset: 0);
}, |
Should be available in 0.1.4, published now. |
@knopp Thanks for your job, your library helps a lot👍 |
life saver |
Hello.
I didn't find any options to customize decorations. So I added an option to remove shadows while dragging as it was my requirement.
Thank you for this cool library!