Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild CI and fix CS #408

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

bocharsky-bw
Copy link
Member

@bocharsky-bw bocharsky-bw commented Jun 29, 2023

After some changes upstream in GitHub CI config: SymfonyCasts/.github#2

@bocharsky-bw
Copy link
Member Author

Seems the lowest support version here is 7.4 so I had to downgrade the PHP version for PHP CS Fixer to 7.4 as well to avoid fixing:

-throw new UnsupportedUserException(sprintf('Instances of "%s" are not supported.', \get_class($user)));
+throw new UnsupportedUserException(sprintf('Instances of "%s" are not supported.', $user::class));

that is not supported by PHP 7.4

@bocharsky-bw bocharsky-bw changed the title Rebuild CI Rebuild CI and fix CS Jun 29, 2023
@weaverryan
Copy link
Member

Thanks Victor!

@weaverryan weaverryan merged commit 47b1c2a into knpuniversity:master Jun 29, 2023
@bocharsky-bw bocharsky-bw deleted the rebuild-ci branch June 29, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants