Add new provider Passage #418
Conversation
|
I don't know why, but a PHPUnit test for PHP 8.2 fails because of a missing dependency. Any ideas? |
|
The failed tests may be unrelated and probably should be fixed in a separate PR, need to double-check if it also fails on master, but definitely needs to be fixed.
About this, mu thoughts are no. 7.4 is EOL now, as also 8.0 will EOL very soon. I think if you support 8.1-8.2 - that's perfect to start. |
| path: ./src/Client/Provider | ||
| - | ||
| message: '#Call to method [a-zA-Z0-9\\_]+\(\) on an unknown class League\\OAuth2\\Client\\Provider\\[a-zA-Z0-9\\_]+\.#' | ||
| path: ./src/Client/Provider |
There was a problem hiding this comment.
Hm, was it required? PHPStan fails without this? IIRC we didn't have problems with it before, but probably PHPStan recent updates start causing it
There was a problem hiding this comment.
PHPStan shows some errors because I added a logout method to the PassageClient.
https://github.com/knpuniversity/oauth2-client-bundle/actions/runs/6580735273/job/17879341475
To logout from Passage you need to be redirected from a allowed logout url which you define in the backend of Passage when you configure OAUTH.
It would be okay for me to remove it from the PassageClient and I will document in malteschlueter/oauth2-passage how to logout.
I missed an implementation of Passage from 1Password that supports Passkeys.
So I've implemented it myself.
Feel free to send me some feedback also for my first own package malteschlueter/oauth2-passage package.
What minimum PHP version should the malteschlueter/oauth2-passage package support? The same as this package
>=7.4?