Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some packages add the b similar when using rc #3

Closed
wants to merge 1 commit into from

Conversation

cpanato
Copy link

@cpanato cpanato commented Jan 18, 2024

Issue #, if available:

Description of changes:

Adding another suffixes, we have a few packages that use the format x.y.x_bw like https://github.com/Azure/azure-sdk-for-python/tree/azure-mgmt-servicefabricmanagedclusters_2.0.0b5

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hectorj2f
Copy link

lgtm

@knqyf263
Copy link
Owner

Is there any documentation somewhere? The PR added b to both preSuffixes and postSuffixes, which confuses me.

Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Author

cpanato commented Jan 19, 2024

updates to only preSuffixes was my mistake.

which kind of documentation are you looking for?

@knqyf263
Copy link
Owner

I'm looking for a document about what b means as a pre-suffix. What about order compared to alpha, beta, etc? (e.g. Is 1.2.3pre1 older than 1.2.3b1?) Is b different from beta?

@cpanato
Copy link
Author

cpanato commented Jan 23, 2024

I'm looking for a document about what b means as a pre-suffix. What about order compared to alpha, beta, etc? (e.g. Is 1.2.3pre1 older than 1.2.3b1?) Is b different from beta?

that is something I cannot answer :( That specific project that I mentioned I did not find any docs for that.
if this makes no sense feel free to close
thanks!

@knqyf263
Copy link
Owner

knqyf263 commented Jan 23, 2024

Actually, I didn't find b even in apk-tools. I'm curious if 2.0.0b5 works with apk.
https://gitlab.alpinelinux.org/alpine/apk-tools/-/blob/acefa1acc1ce0e1871d17b4eafe4b1888f45d4d0/src/version.c#L73-74

Isn't it violating the apk version specification? I just want this library to comply with apk versioning.

@cpanato
Copy link
Author

cpanato commented Jan 23, 2024

i think so, thanks! i will close this pr

@cpanato cpanato closed this Jan 23, 2024
@knqyf263
Copy link
Owner

If we confirm it should work with apk, we can reopen this PR. Thanks for your contribution.

@cpanato
Copy link
Author

cpanato commented Jan 23, 2024

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants