Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable LTO #61

Merged
merged 1 commit into from
Jan 5, 2022
Merged

disable LTO #61

merged 1 commit into from
Jan 5, 2022

Conversation

japaric
Copy link
Member

@japaric japaric commented Jan 4, 2022

to work around rustc issue 90357

to work around rustc issue 90357
@Urhengulas Urhengulas merged commit b4327d0 into main Jan 5, 2022
@Urhengulas Urhengulas deleted the disable-lto branch January 5, 2022 11:36
@rockboynton
Copy link

this breaks rust-analyzer... it needs to not be a string:

lto = false

@Urhengulas
Copy link
Member

Urhengulas commented Jun 27, 2022

@rockboynton With "breaks" you mean RA emits a warning, correct? Because it still works for me in the current form , it just underlines the "lto".

We can change that for sure. Do you want to send a patch? Nevertheless I am wondering if RA should also accept "false" and "true", because rustc does accept it.

Edit: the underlining comes from another extension, not RA

@Urhengulas
Copy link
Member

Looking more into it, it seems that this results in an actual error in rust nightly, while it still works on stable.

$ cargo build --bins
   Compiling krate v0.1.0 (/home/urhengulas/Documents/github.com/knurling-rs/krate)
    Finished dev [optimized + debuginfo] target(s) in 0.16s

$ cargo +nightly build --bins
error: failed to parse manifest at `/home/urhengulas/Documents/github.com/knurling-rs/krate/Cargo.toml`

Caused by:
  `lto` setting of string `"false"` for `bench` profile is not a valid setting, must be a boolean (`true`/`false`) or a string (`"thin"`/`"fat"`/`"off"`) or omitted.

Urhengulas added a commit that referenced this pull request Jun 27, 2022
Urhengulas added a commit that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants