Add impls for Chrono structs #893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Missed out Days as there is no way to access it's field so nothing to format - Gated behind new "chrono" feature
|
Have you tried submitting defmt support to Chrono? As far as I know, we don't currently host any third-party defmt implementations - only ones for libcore types. |
|
Sorry, I didn't see this was related to #763 (please do tag issues if you're working against something specific). Let me talk to Johann. |
|
OK, we're going to try and send a PR upstream and if that fails, we can come back to this one. |
|
What did chrono say? |
|
I found this open PR: chronotope/chrono#1632. Seems they want to wait for defmt to release 1.0 |
|
Closing this PR and noting the chrono PR in the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #763