Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore comments in linker script (fix) #84

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Conversation

BriocheBerlin
Copy link
Contributor

With b7f5568 comments in linker scripts were no longer ignored. This fixes that.

Closes #83

@BriocheBerlin BriocheBerlin force-pushed the fix_comments_in_linker branch from b02da71 to 117e1ac Compare November 1, 2023 11:53
Copy link

@amanjeev amanjeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly the comment after the end of line for each line right?

Thank you for this fix!

@BriocheBerlin BriocheBerlin added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit 1cebcec Nov 7, 2023
5 checks passed
@BriocheBerlin BriocheBerlin deleted the fix_comments_in_linker branch November 7, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments in memory.x are not properly handled
2 participants