Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for @file args #96

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Add support for @file args #96

merged 5 commits into from
Aug 14, 2024

Conversation

great-houk
Copy link
Contributor

Fixes #95

I couldn't reproduce the original error I encountered, so I couldn't test if this works with rustc generated files, but based on the code for my initial fix, it should work. If someone can find a way to make rustc emit the at-file args so this can be properly tested, that would be great, but I'm very confident in it as it is.

Copy link
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one nit

src/argument_parser.rs Outdated Show resolved Hide resolved
@great-houk great-houk requested a review from Urhengulas August 2, 2024 22:18
@Urhengulas Urhengulas added this pull request to the merge queue Aug 14, 2024
Merged via the queue into knurling-rs:main with commit dcd8e10 Aug 14, 2024
10 checks passed
@great-houk great-houk deleted the @file-args branch August 19, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support rust lld @file command line arguments
2 participants