This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
don't print <exception entry> more thn once per frame #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japaric
commented
Nov 20, 2020
| @@ -747,7 +747,6 @@ fn backtrace( | |||
| if top_exception.is_none() { | |||
There was a problem hiding this comment.
I'm not sure the code comment above this line applies anymore. the code inside the if checks for a stack overflow but doesn't do special logic around unwinding the frame. The frame is unwound normally using the logic in line 797.
probably the code around this can be simplified now that we put a breakpoint on HardFaultTrampoline
There was a problem hiding this comment.
Yeah, seems like a good idea. I do find the code in probe-run to be a bit hard to follow sometimes.
jonas-schievink
approved these changes
Nov 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as far as I could test
HardFaultTrampolinealways has a special LR value so we always enter the block at line 797 and print<exception entry>fixes #59