This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Backtrace options #250
Merged
Backtrace options #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no_backtrace test.
Lotterleben
reviewed
Aug 18, 2021
| #[test] | ||
| // this test should not be run by default, as it requires the target hardware to be present | ||
| #[ignore] | ||
| fn successful_run_can_enforce_backtrace() { |
There was a problem hiding this comment.
why is this deleted and not adapted?
There was a problem hiding this comment.
Didn't realize at first that we keep the functionality (under a different name). Adapted!
Functionality still missing.
…dds snapshot tests.
Lotterleben
reviewed
Aug 24, 2021
src/backtrace/mod.rs
Outdated
| || contains_exception { | ||
| true | ||
| } else { | ||
| false |
There was a problem hiding this comment.
this if...else can be left out because the settings.panic_present || unwind.outcome == Outcome::StackOverflow || ... statement itself evaluates to a bool, which is what we want to return. e.g.:
BacktraceOptions::Auto => settings.panic_present
|| unwind.outcome == Outcome::StackOverflow
|| unwind.corrupted
|| contains_exception should work as well
Lotterleben
reviewed
Aug 24, 2021
src/backtrace/mod.rs
Outdated
| || unwind.outcome == Outcome::StackOverflow | ||
| || unwind.corrupted | ||
| || contains_exception; | ||
| let print_backtrace= match settings.backtrace { |
Adds urhengulas comment that indicates where `--backtrace-limit=0 is accepted and means "no limit"` functionality is implented. Co-authored-by: Johann Hemmann <johann.hemmann@code.berlin>
|
bors r+ |
|
Build succeeded: |
japaric
added a commit
that referenced
this pull request
Sep 15, 2021
Merged
japaric
added a commit
that referenced
this pull request
Sep 15, 2021
japaric
added a commit
that referenced
this pull request
Sep 16, 2021
japaric
added a commit
that referenced
this pull request
Sep 16, 2021
japaric
added a commit
that referenced
this pull request
Sep 16, 2021
7 tasks
bors bot
added a commit
to knurling-rs/defmt
that referenced
this pull request
Oct 19, 2021
547: Migration guide `v0.2.x` to `v0.3.0` r=japaric a=Urhengulas Migration guide from `defmt v0.2.x` to version `v0.3.0`. https://deploy-preview-547--admiring-dubinsky-56dff5.netlify.app/migration-02-03.html Fixes #530. ### TODO - [x] #505: Logger trait v2 - [x] #521: [3/n] Remove u24 - [x] #522: Replace `µs` hint with `us` - [x] (no adaption needed) ~~#508: [5/n] Format trait v2~~ - [x] #519: `DEFMT_LOG` - [x] #550: `defmt::flush()` - [x] knurling-rs/probe-run#198, knurling-rs/probe-run#250, Co-authored-by: Johann Hemmann <johann.hemmann@code.berlin>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #198