use new stream decoder API #264
Conversation
also include source code so it's easier to regenerate them in the future also reduce the size of the stack overflow snapshot
|
I think it would be good to set up the unit tests to always be built from source, that makes it easier to modify them bors r+ |
|
Build succeeded: |
generally +1 to the idea of having the source in-tree. always rebuilding the snapshot binaries does have the complication that stuff can vary between systems and break the tests e.g. file paths, binary sizes, etc. resilience against that would require sort of wildcards in the .snap files ( |
| } | ||
|
|
||
| Err(defmt_decoder::DecodeError::UnexpectedEof) => break, | ||
|
|
||
| Err(defmt_decoder::DecodeError::Malformed) => { | ||
| log::error!("failed to decode defmt data: {:x?}", buffer); | ||
| log::error!("failed to decode defmt data"); |
There was a problem hiding this comment.
by the way, @Urhengulas this looked like the right place to modify to implement #249 (I think)
fixes knurling-rs/defmt#575
marking as a draft because I want to update the manual snapshot tests before merging this