Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Update probe-rs to version 0.13.0 #329

Merged
merged 5 commits into from
Jul 14, 2022
Merged

Conversation

jannic
Copy link
Contributor

@jannic jannic commented Jul 12, 2022

This patch doesn't implement 64-bit support, but only inserts
conversions from u32 to u64 where necessary.

This patch doesn't implement 64-bit support, but only inserts
conversions from u32 to u64 where necessary.
Copy link
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! There are a lot of conversions going on, but I think we can clean this i
up later™ 😆

A small understanding question: With "64-bit support" you mean properly using u64 and not just doing conversions all over the place. Or is there anything else needed for 64-bit support?

src/target_info.rs Outdated Show resolved Hide resolved
src/registers.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/target_info.rs Outdated Show resolved Hide resolved
Copy link
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

Copy link
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reacting to the code review. Two more small things (comment regarding wrapping_add_signed and the question about the target).

src/target_info.rs Outdated Show resolved Hide resolved
@Urhengulas
Copy link
Member

Thank you!

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 14, 2022

Build succeeded:

@bors bors bot merged commit 88f0afc into knurling-rs:main Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants