-
-
Notifications
You must be signed in to change notification settings - Fork 75
Conversation
This patch doesn't implement 64-bit support, but only inserts conversions from u32 to u64 where necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! There are a lot of conversions going on, but I think we can clean this i
up later™ 😆
A small understanding question: With "64-bit support" you mean properly using u64 and not just doing conversions all over the place. Or is there anything else needed for 64-bit support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reacting to the code review. Two more small things (comment regarding wrapping_add_signed
and the question about the target).
Thank you! bors r+ |
Build succeeded: |
This patch doesn't implement 64-bit support, but only inserts
conversions from u32 to u64 where necessary.