Add option to verify written flash

[suyashb95]

• add option to verify written flash
• fixes Add option to verify flash #236

[suyashb95]

@Urhengulas I've got an ST Link JTAG programmer and an ESP32, would love some tips on testing this out!

[Urhengulas]

@Urhengulas I've got an ST Link JTAG programmer and an ESP32, would love some tips on testing this out!

Sure!

1. Install your local probe-run

   $ cd path/to/probe-run
   $ cargo install --path .

2. Set up the https://github.com/knurling-rs/app-template for your board
3. Add the --verify option to the runner in .cargo/config.toml (link)
4. Then just run a few of the examples, e.g.:

   $ cargo rb hello

5. Try it in combination with some of the other configuration flags, e.g. --measure-stack, --no-flash, --connect-under-reset
6. If that behaves as expected you can mark the PR as ready for review.

PS: Please add the change to the CHANGELOG.md.

[suyashb95]

@Urhengulas I've got an ST Link JTAG programmer and an ESP32, would love some tips on testing this out!

Sure!

1. Install your local probe-run

   $ cd path/to/probe-run
   $ cargo install --path .
   

2. Set up the https://github.com/knurling-rs/app-template for your board
3. Add the --verify option to the runner in .cargo/config.toml (link)
4. Then just run a few of the examples, e.g.:

   $ cargo rb hello
   

5. Try it in combination with some of the other configuration flags, e.g. --measure-stack, --no-flash, --connect-under-reset
6. If that behaves as expected you can mark the PR as ready for review.

PS: Please add the change to the CHANGELOG.md.

@Urhengulas Turns out the ST Link debuggers don't work with the ESP32
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/jtag-debugging/index.html#jtag-debugging-selecting-jtag-adapter

Would it be possible to test this out on your end?

[Urhengulas]

I tested it and it seems to verify it. At least the probe-rs logs say so.

Looking into the code I realized that the --verify option would be skipped, if used together with --no-flash. Can you therefore please change the attribute of no_flash (not verify!) to following:

/// Skip writing the application binary to flash.
-    #[structopt(long, conflicts_with = "defmt")]
+    #[structopt(
+        long,
+        conflicts_with = "disable-double-buffering",
+        conflicts_with = "verify"
+    )]
    pub no_flash: bool,

(defmt isn't needed anymore, and disable-double-buffering has no effect with --no-flash as well)

Other than that it looks good to me!

[Urhengulas]

bors r+

[bors]

Build failed:

• ci

[Urhengulas]

Can you please run cargo fmt?
Afterwards you can use bors r+ to merge.

bors d+

[bors]

✌️ Suyash458 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

[suyashb95]

bors r+

[bors]

Build succeeded:

• ci